handle openmp deprecation - #7882
Conversation
Resolves the following warning: fread.c:2479:15: warning: ‘master’ construct deprecated since OpenMP 5.1, use ‘masked’ [-Wdeprecated-openmp]
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7882 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 88 88
Lines 17309 17309
=======================================
Hits 17139 17139
Misses 170 170 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
FI - looks like this is now flagged by CRAN (see https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-gcc/data.table-00check.html)
|
|
Thank you very much, this is quite handy for the impending patch release.
...and we don't use the |
Resolves the following warning: fread.c:2479:15: warning: ‘master’ construct deprecated since OpenMP 5.1, use ‘masked’ [-Wdeprecated-openmp]
|
@TimTaylor looks like you'll be our 100th project member! PRs created from branches inside Cc: @tdhock |
|
...this will need a NEWS item and a DESCRIPTION patch, won't it? |
Building locally I saw the the following warning:
Link to relevant documentation:
https://www.openmp.org/spec-html/5.1/openmpse16.html
Note I'm unsure on the potential use of the
filterclause so it is probably worth digging in to a little first.